Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-editor-support] update TypeScript definition #5625

Merged
merged 9 commits into from
Feb 21, 2018
Merged

[jest-editor-support] update TypeScript definition #5625

merged 9 commits into from
Feb 21, 2018

Conversation

stephtr
Copy link
Contributor

@stephtr stephtr commented Feb 20, 2018

Summary

The TypeScript definition within jest-editor-support was outdated. I have updated it based on the Flow type files.

Test plan

There shouldn't be necessary any tests as I copied them from the existing code. The only non-backward-compatible change is replacing **M**essageTypes by **m**essageTypes in order to keep it consistent to the Flow type file.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

codecov-io commented Feb 20, 2018

Codecov Report

Merging #5625 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5625   +/-   ##
======================================
  Coverage    60.9%   60.9%           
======================================
  Files         215     215           
  Lines        7325    7325           
  Branches        3       3           
======================================
  Hits         4461    4461           
  Misses       2863    2863           
  Partials        1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da90886...aad36c1. Read the comment docs.

@cpojer cpojer requested a review from orta February 20, 2018 21:17
@orta
Copy link
Member

orta commented Feb 21, 2018

Yep - perfect thanks @stephtr / @cpojer

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants