-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to spawn command in a shell #5340
Conversation
Not sure what's up with Circle CI. The "restoring cache" step is failing:
I've tried amending the last commit, popping a commit off the branch and re-committing fresh, and I'm not having any luck. 😭 |
Shouldn't |
) => ChildProcess, | ||
testNamePattern?: string, | ||
testFileNamePattern?: string, | ||
shell?: boolean, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephtr, you're right. These two type definitions have diverged.
https://github.com/facebook/jest/blob/master/packages/jest-editor-support/index.d.ts#L11
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This adds the option to spawn a Jest command in a shell from
jest-editor-support
. On Windows, using theshell
option will handle adding the.cmd
and.bat
extensions to thepathToJest
.The issue is discussed in jest-community/vscode-jest#98.
Test plan
Unit tests have been added.