-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make --lastCommit and --changedFilesWithAncestor work without --onlyChanged #5307
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5307 +/- ##
=======================================
Coverage 61.23% 61.23%
=======================================
Files 205 205
Lines 6891 6891
Branches 4 3 -1
=======================================
Hits 4220 4220
Misses 2670 2670
Partials 1 1 Continue to review full report at Codecov.
|
51177a7
to
fc53821
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the changelog?
fc53821
to
31fd272
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This came up in a discussion on another PR of mine, so I decided to fix it: #5189 (comment)
Test plan
before this change, all 3 commands would output
220