Call chalk.inverse for trailing spaces in jest-matcher-utils #4578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reduce package coupling and eliminate potential inconsistency between fg and bg colors.
Make
printExpected
andprintReceived
follow example ofprintActualErrorMessage
to color trailing spaces within the string before coloring the entire string, because closing escape sequence for foreground color preceding newline causes regex for background color not to match.Test plan
matchers.test.js
to-throw-matchers.js
P.S. Again to Yarn team: we who are about to test (package interdependencies) salute you!