-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow upgrade #4355
Flow upgrade #4355
Conversation
@SimenB Although I am happy to make these changes, it might be more efficient for you:
|
Thanks for the help @pedrottimark! I chose to use |
Codecov Report
@@ Coverage Diff @@
## master #4355 +/- ##
=======================================
Coverage 55.85% 55.85%
=======================================
Files 189 189
Lines 6383 6383
Branches 6 6
=======================================
Hits 3565 3565
Misses 2815 2815
Partials 3 3
Continue to review full report at Codecov.
|
You’re welcome. Thank you for explaining. Y’all have a lot to teach me about fluent JS and Flow. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Tried to upgrade, and using
flow-upgrade
, but there's still tons of errors in pretty-format tests. I'm guessing I shouldn't just litter the tests withFlowFixMe
s?/cc @pedrottimark
Test plan
yarn flow
(currently failing)