Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add skipped tests support for jest-editor-support #4346

Merged
merged 1 commit into from
Aug 24, 2017
Merged

add skipped tests support for jest-editor-support #4346

merged 1 commit into from
Aug 24, 2017

Conversation

bookman25
Copy link
Contributor

Summary

Allow jest-editor-support to distinguish skipped tests

Test plan

Automated test added

@bookman25
Copy link
Contributor Author

@orta heads up

@cpojer
Copy link
Member

cpojer commented Aug 24, 2017

Sweet! Please run yarn lint and fix everything up. I'll leave it to @orta to review.

@bookman25
Copy link
Contributor Author

Yeah, not sure what happened there. formatOnSave in the vscode settings was doing weird things and not respecting prettier.

@thymikee
Copy link
Collaborator

@bookman25 probably version mismatch?

@bookman25
Copy link
Contributor Author

Nope even better... didn't have the prettier plugin installed on this machine 👍 thanks @thymikee

@orta
Copy link
Member

orta commented Aug 24, 2017

Thanks @cpojer - this looks 👍 to me, I'm not an collaborator so can't leave a big green tick, so have this salad instead: 🥗

@orta
Copy link
Member

orta commented Aug 24, 2017

I know the appveyor has been unreliable for a bit, so that's ok - the travis-PR one looks real weird.

@bookman25
Copy link
Contributor Author

Looks like the same failures are showing up in master right now as well.

@cpojer cpojer merged commit 193d646 into jestjs:master Aug 24, 2017
@bookman25 bookman25 deleted the editor branch June 9, 2019 09:56
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants