Join lines with newline in jest-diff

[pedrottimark]

Summary

Join lines with newline instead of concatenating newline to each line, and then trimming result.

Is the trim method redundant? What about leading spaces? Glad you asked:

• For default --colors option, ansi codes “protect” leading space if first line is unchanged.
• For --no-colors option, leading space is trimmed. Inconsistent and seems like a bug.

Test plan

If you approve, I will update this PR:

• delete 2 occurrences of trim method
• update snapshot works with node assert in integration_tests/__tests__/failures.test.js

-    Object {
+      Object {
         "a": Object {
           "b": Object {
     -       "c": 6,
     +       "c": 5,
           },

-    Object {
+      Object {
         "a": Object {
           "b": Object {
     -       "c": 7,
     +       "c": 5,
           },

-    Object {
+      Object {
     -   "a": 2,
     +   "a": 1,
       }

[cpojer]

works for me. Can you update the PR?

[pedrottimark]

Yes, updated :)

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.