Replace match with test and omit redundant String conversion in jest-diff #4311
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RegExp.test
becauseString.match
is equivalent toRegExp.exec
which returns eithernull
or an array, therefore first condition was always false.String
constructor, becauseswitch (aType) case 'string'
and have already returned ifexpectedType !== getType(b)
or string asymmetric matcher.Test plan
stripAnsi
from 2 existing tests withtoBe(null)
assertion