Ignore import type for extract_requires #4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elicwhite
commented
Jul 19, 2017
| @@ -12,8 +12,8 @@ const blockCommentRe = /\/\*[^]*?\*\//g; | |||
| const lineCommentRe = /\/\/.*/g; | |||
|
|
|||
| const replacePatterns = { | |||
| EXPORT_RE: /(\bexport\s+(?:[^'"]+\s+from\s+)??)(['"])([^'"]+)(\2)/g, | |||
There was a problem hiding this comment.
Are there any tests that cover this currently? I didn't see anything and I'm not sure how it is used so I wasn't able to add a test for this.
There was a problem hiding this comment.
Nope, probably no tests :) Feel free to send one, it's the same as import, just that it exports also:
export foo from 'foo-module';
export type foo from 'foo-module';
we want to ignore the latter.
|
Thank you! Feel free to send a follow-up PR with more tests. |
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract_requires shouldn't be looking at dependencies only used for flow types.
Test plan
Unit tests