jest-haste-map: add test+fix for broken platform module support #3885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanlauliac
force-pushed
the
platform-change-bug-fix
branch
from
d92bea9
to
2f80754
Compare
Codecov Report
@@ Coverage Diff @@
## master #3885 +/- ##
==========================================
+ Coverage 58.07% 58.12% +0.04%
==========================================
Files 195 195
Lines 6734 6741 +7
Branches 6 6
==========================================
+ Hits 3911 3918 +7
Misses 2820 2820
Partials 3 3
Continue to review full report at Codecov.
|
|
Looks good. Can you rebase this quickly? |
jeanlauliac
force-pushed
the
platform-change-bug-fix
branch
from
2f80754
to
c3e43cd
Compare
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two platform variants of a single module ID change at the same time (ex. often happening after a far rebase), jest was loosing one of them, depending on the ordering of the change events. This is because it doesn't care about platform variants and deletes the whole module metadata every time. This is probably here for historical reasons, from before the introduction of platform extensions, and wasn't unit-tested.
This changeset adds a test and the corresponding fix for this behaviour. I wrote the test first and could see it failing if the correct fix is not added as well.