Fixed object matcher #3799
Merged
Fixed object matcher #3799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Jun 12, 2017
| @@ -79,7 +79,7 @@ const getObjectSubset = (object: Object, subset: Object) => { | |||
| ) { | |||
| const trimmed = {}; | |||
| Object.keys(subset) | |||
| .filter(key => object.hasOwnProperty(key)) | |||
| .filter(key => hasOwnProperty(object, key)) | |||
There was a problem hiding this comment.
Must have missed that, thanks!
Codecov Report
@@ Coverage Diff @@
## master #3799 +/- ##
=======================================
Coverage 57.58% 57.58%
=======================================
Files 194 194
Lines 6776 6776
Branches 6 6
=======================================
Hits 3902 3902
Misses 2871 2871
Partials 3 3
Continue to review full report at Codecov.
|
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the object matcher utility to use hasOwnProperty independent of the object passed.
Before,
expect(Object.create(null)).toMatchObject(someObject)would throw an error, as Object.create(null) lacks the object prototype.It appears that you all had already noticed this as you had created a helper for it, but weren't actually using it.
Test plan
yarn run jest --silent && yarn run test-examples --silent