Failure when coverage threshold not met #3554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 11, 2017 15:47
See: jestjs#3520 Fixed async calls to each reporter onRunComplete method
|
This is great! Could you add an integration test in the integration_tests folder. |
|
Sure, I will look into it. |
Codecov Report
@@ Coverage Diff @@
## master #3554 +/- ##
=======================================
Coverage 62.28% 62.28%
=======================================
Files 181 181
Lines 6714 6714
Branches 6 6
=======================================
Hits 4182 4182
Misses 2529 2529
Partials 3 3
Continue to review full report at Codecov.
|
|
this is awesome! thank you! |
orta
pushed a commit
to orta/jest
that referenced
this pull request
Jul 7, 2017
* Return failure when coverage threshold isn’t met See: jestjs#3520 Fixed async calls to each reporter onRunComplete method * Run prettier
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* Return failure when coverage threshold isn’t met See: jestjs#3520 Fixed async calls to each reporter onRunComplete method * Run prettier
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3520
Fixed async calls to each reporter onRunComplete method
Summary
Whenever the
coverageis enabled, jest exits with 0 even if the threshold requirements are not met.The Coverage reporter will not return a resolved promise when
collectCoverageFrommatches files and consequently the Dispatcher will resolve theonRunCompletepromise before collecting the result from reporter.