jest-config: UID needs to be part of top-level folder #3387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought about doing it this way before but I was worried that |
|
I tried it out in node REPL, it worked fine, but I'll add the |
|
Because it could change in future version of Node with no warning, in fact. |
|
👍 |
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* jest-config: UID needs to be part of top-level folder * pass the 'process' instance to getuid()
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If
jestruns first asroot, then as non-root, then the top-level/tmp/jestfolder will be owned by root and will not allow write permissions for the non-rootinstance. So we need to use completely different top-level folders for each user. We assume that we always have write permissions on the top-level/tmpor whicheveros.tmpdir()returns.Test plan
Automated testing.