chore(lint): enable recommended configs (#12902)

Author: SimenB

.eslintrc.cjs

@@ -5,6 +5,8 @@
  * LICENSE file in the root directory of this source tree.
  */
 
+/* eslint-disable sort-keys */
+
 const fs = require('fs');
 const path = require('path');
 const {sync: readPkg} = require('read-pkg');
@@ -27,6 +29,7 @@ module.exports = {
     'jest/globals': true,
   },
   extends: [
+    'eslint:recommended',
     'plugin:markdown/recommended',
     'plugin:import/errors',
     'plugin:eslint-comments/recommended',
@@ -38,6 +41,7 @@ module.exports = {
   overrides: [
     {
       extends: [
+        'plugin:@typescript-eslint/recommended',
         'plugin:@typescript-eslint/eslint-recommended',
         'plugin:import/typescript',
       ],
@@ -52,10 +56,14 @@ module.exports = {
           {argsIgnorePattern: '^_'},
         ],
         '@typescript-eslint/prefer-ts-expect-error': 'error',
+        '@typescript-eslint/no-var-requires': 'off',
         // TS verifies these
         'consistent-return': 'off',
         'no-dupe-class-members': 'off',
         'no-unused-vars': 'off',
+        // TODO: enable at some point
+        '@typescript-eslint/no-explicit-any': 'off',
+        '@typescript-eslint/no-non-null-assertion': 'off',
       },
     },
     {
@@ -144,6 +152,9 @@ module.exports = {
       files: ['**/*.md/**'],
       rules: {
         '@typescript-eslint/no-unused-vars': 'off',
+        '@typescript-eslint/no-empty-function': 'off',
+        '@typescript-eslint/no-namespace': 'off',
+        '@typescript-eslint/no-empty-interface': 'off',
         'arrow-body-style': 'off',
         'consistent-return': 'off',
         'import/export': 'off',
@@ -201,6 +212,13 @@ module.exports = {
         ],
       },
     },
+    {
+      files: ['**/__tests__/**', '**/__mocks__/**'],
+      rules: {
+        '@typescript-eslint/ban-ts-comment': 'off',
+        '@typescript-eslint/no-empty-function': 'off',
+      },
+    },
     {
       files: [
         '**/__tests__/**',
@@ -247,6 +265,12 @@ module.exports = {
         'import/no-extraneous-dependencies': 'off',
       },
     },
+    {
+      files: ['**/__typetests__/**'],
+      rules: {
+        '@typescript-eslint/no-empty-function': 'off',
+      },
+    },
     {
       files: [
         '**/__typetests__/**',

e2e/__tests__/multiProjectRunner.test.ts

@@ -49,7 +49,7 @@ test('can pass projects or global config', () => {
         getHasteName(filename) {
           return filename
             .substr(filename.lastIndexOf(path.sep) + 1)
-            .replace(/\.js$/, '');
+            .replace(/\\.js$/, '');
         },
       };
     `,
@@ -446,7 +446,7 @@ test('Does transform files with the corresponding project transformer', () => {
     'project1/jest.config.js': `
       module.exports = {
         rootDir: './',
-        transform: {'file\.js': './transformer.js'},
+        transform: {'file\\.js': './transformer.js'},
       };`,
     'project1/transformer.js': `
       module.exports = {
@@ -461,7 +461,7 @@ test('Does transform files with the corresponding project transformer', () => {
     'project2/jest.config.js': `
       module.exports = {
         rootDir: './',
-        transform: {'file\.js': './transformer.js'},
+        transform: {'file\\.js': './transformer.js'},
       };`,
     'project2/transformer.js': `
       module.exports = {

e2e/__tests__/runProgrammatically.test.ts

@@ -12,10 +12,10 @@ const dir = resolve(__dirname, '..', 'run-programmatically');
 
 test('run Jest programmatically cjs', () => {
   const {stdout} = run('node cjs.js --version', dir);
-  expect(stdout).toMatch(/\d{2}\.\d{1,2}\.\d{1,2}[\-\S]*-dev$/);
+  expect(stdout).toMatch(/\d{2}\.\d{1,2}\.\d{1,2}[-\S]*-dev$/);
 });
 
 test('run Jest programmatically esm', () => {
   const {stdout} = run('node index.js --version', dir);
-  expect(stdout).toMatch(/\d{2}\.\d{1,2}\.\d{1,2}[\-\S]*-dev$/);
+  expect(stdout).toMatch(/\d{2}\.\d{1,2}\.\d{1,2}[-\S]*-dev$/);
 });

e2e/__tests__/version.test.ts

@@ -22,7 +22,7 @@ test('works with jest.config.js', () => {
   });
 
   const {exitCode, stdout, stderr} = runJest(DIR, ['--version']);
-  expect(stdout).toMatch(/\d{2}\.\d{1,2}\.\d{1,2}[\-\S]*-dev$/);
+  expect(stdout).toMatch(/\d{2}\.\d{1,2}\.\d{1,2}[-\S]*-dev$/);
   // Only version gets printed and nothing else
   expect(stdout.split(/\n/)).toHaveLength(1);
   expect(stderr).toBe('');

e2e/coverage-provider-v8/empty-sourcemap/types.ts

@@ -5,4 +5,5 @@
  * LICENSE file in the root directory of this source tree.
  */
 
+// eslint-disable-next-line @typescript-eslint/no-empty-interface
 export interface obj {}

e2e/snapshot-escape/__tests__/snapshotEscapeRegex.js

@@ -6,7 +6,7 @@
  */
 'use strict';
 
-const regex = /\dd\ \s+ \w \\\[ \. blahzz.* [xyz]+/;
+const regex = /\dd \s+ \w \\\[ \. blahzz.* [xyz]+/;
 
 test('escape regex', () => expect(regex).toMatchSnapshot());
 

packages/babel-plugin-jest-hoist/src/index.ts

@@ -305,6 +305,7 @@ export default function jestHoist(): PluginObj<{
     },
     // in `post` to make sure we come after an import transform and can unshift above the `require`s
     post({path: program}) {
+      // eslint-disable-next-line @typescript-eslint/no-this-alias
       const self = this;
 
       visitBlock(program);

packages/expect/src/index.ts

@@ -64,6 +64,7 @@ export class JestAssertionError extends Error {
   matcherResult?: Omit<SyncExpectationResult, 'message'> & {message: string};
 }
 
+// eslint-disable-next-line @typescript-eslint/no-unnecessary-type-constraint
 const isPromise = <T extends any>(obj: any): obj is PromiseLike<T> =>
   !!obj &&
   (typeof obj === 'object' || typeof obj === 'function') &&

packages/jest-circus/src/index.ts

@@ -155,6 +155,7 @@ const test: Global.It = (() => {
         test.todo,
       );
     }
+    // eslint-disable-next-line @typescript-eslint/no-empty-function
     return _addTest(testName, 'todo', false, () => {}, test.todo);
   };
 

packages/jest-circus/src/legacy-code-todo-rewrite/jestAdapterInit.ts

@@ -63,7 +63,7 @@ export const initialize = async ({
   }
   getRunnerState().maxConcurrency = globalConfig.maxConcurrency;
 
-  // @ts-expect-error
+  // @ts-expect-error: missing `concurrent` which is added later
   const globalsObject: Global.TestFrameworkGlobals = {
     ...globals,
     fdescribe: globals.describe.only,