Update configure.sh to use the correct LLVM_BUILD_DIR #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
willholen
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
@dulinriley is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@dulinriley merged this pull request in 3ed8340. |
Closed
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For people that specify a specific LLVM_BUILD_DIR, make sure configure.sh respects that.
Before this change, it would add LLVM_BUILD_DIR to HERMES_WS_DIR, but LLVM_BUILD_DIR is supposed to be an absolute path.