-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regex fails on RN #231
Comments
RN 0.61.5 is a release from November 2019. The Hermes regex parser bug was likely fixed in the series of commits near edeef8a, which is why updating Hermes and RN should fix your issue. Closing because the fix is already in master. |
Still facing the issue on RN 0.66.0 and Hermes 0.9.0 |
@roots-ai I just tested the regex given in the issue and it works in Hermes 0.9.0, which I downloaded from the releases page. |
@avp I have the same issue on the new hermes version with [email protected]. I tested the regex |
@Abrax20 looks like that uses a named capture group, which isn't a supported feature of the Hermes RegExp engine yet. You can check https://github.com/facebook/hermes/blob/main/doc/RegExp.md for more information on which RegExp features Hermes supports right now. |
The RegEx
/^{+\/?|\/?}+$/
fails on RN 0.61.5 with errorBut the regex works fine on hermes build from master.
Changing the regex to
/^\{+\/?|\/?\}+$/
also works.The text was updated successfully, but these errors were encountered: