Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"HBC version" should be reflected in the documentation or the file name #1449

Closed
qq741079111 opened this issue Jun 26, 2024 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@qq741079111
Copy link

I need a "hbcdump" tool with "HBC version==94", but I cannot find it. I can only download the source code one version at a time and open "include \ themes \ BCGen \ HBC \ BytecodeVersion. h" to view it.

@qq741079111 qq741079111 added the enhancement New feature or request label Jun 26, 2024
@tmikov
Copy link
Contributor

tmikov commented Jun 26, 2024

Hi, as far as I understand, you are asking whether we are planning to develop a tool that can disassemble multiple bytecode versions, or alternatively a collection of binaries for different versions.

Unfortunately, this is out of scope for Hermes - at any time we only support the current version of the bytecode. We do not provide backward compatibility with different bytecode versions, so there is no value for us in maintaining a tool to disassemble multiple versions. Additionally, as of the next major version of Hermes (Static Hermes), bytecode versions will change at most at major releases, so for practical purposes the Hermes version will identify the bytecode version.

Anyway, if the ability to disassemble multiple versions at a time is needed, a separate open source project could compile different versions of hbcdump and package them with a front-end tool that invokes the correct one.

Snapshots of the source tree for each version can be obtained from here: https://github.com/facebook/hermes/commits/main/include/hermes/BCGen/HBC/BytecodeVersion.h.

@tmikov tmikov closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants