diff --git a/API/hermes/cdp/RuntimeDomainAgent.cpp b/API/hermes/cdp/RuntimeDomainAgent.cpp index 0f3132dda36..af6215884de 100644 --- a/API/hermes/cdp/RuntimeDomainAgent.cpp +++ b/API/hermes/cdp/RuntimeDomainAgent.cpp @@ -675,7 +675,7 @@ void RuntimeDomainAgent::callFunctionOn( evalResult = runtime_.evaluateJavaScript( std::unique_ptr(new jsi::StringBuffer(expression)), kEvaluatedCodeUrl); - } catch (const jsi::JSIException &error) { + } catch (const jsi::JSIException &) { sendResponseToClient(m::makeErrorResponse( req.id, m::ErrorCode::InternalError, @@ -883,7 +883,7 @@ RuntimeDomainAgent::makePropsFromValue( desc.wasThrown = true; desc.value = m::runtime::makeRemoteObjectForError( runtime, err.value(), *objTable_, objectGroup); - } catch (const jsi::JSIException &err) { + } catch (const jsi::JSIException &) { desc.wasThrown = true; desc.value = m::runtime::makeRemoteObject( runtime, diff --git a/API/hermes/inspector/chrome/CDPHandler.cpp b/API/hermes/inspector/chrome/CDPHandler.cpp index d4569bafb31..1ba161b120b 100644 --- a/API/hermes/inspector/chrome/CDPHandler.cpp +++ b/API/hermes/inspector/chrome/CDPHandler.cpp @@ -1711,7 +1711,7 @@ std::vector CDPHandlerImpl::makePropsFromValue( jsi::Value propValue = obj.getProperty(runtime, propName); desc.value = m::runtime::makeRemoteObject( runtime, propValue, objTable_, objectGroup, false, generatePreview); - } catch (const jsi::JSError &err) { + } catch (const jsi::JSError &) { // We fetched a property with a getter that threw. Show a placeholder. // We could have added additional info, but the UI quickly gets messy. desc.value = m::runtime::makeRemoteObject( diff --git a/API/hermes/inspector/chrome/RemoteObjectConverters.cpp b/API/hermes/inspector/chrome/RemoteObjectConverters.cpp index d53e77493fb..e348f8571cb 100644 --- a/API/hermes/inspector/chrome/RemoteObjectConverters.cpp +++ b/API/hermes/inspector/chrome/RemoteObjectConverters.cpp @@ -82,7 +82,7 @@ static m::runtime::ObjectPreview generateArrayPreview( try { desc = generatePropertyPreview( runtime, indexString, obj.getValueAtIndex(runtime, i)); - } catch (const jsi::JSError &err) { + } catch (const jsi::JSError &) { desc.name = indexString; desc.type = "string"; desc.value = ""; @@ -121,7 +121,7 @@ static m::runtime::ObjectPreview generateObjectPreview( // Chrome instead detects getters and makes you click to invoke. desc = generatePropertyPreview( runtime, propName.utf8(runtime), obj.getProperty(runtime, propName)); - } catch (const jsi::JSError &err) { + } catch (const jsi::JSError &) { desc.name = propName.utf8(runtime); desc.type = "string"; desc.value = ""; diff --git a/API/hermes/inspector/chrome/tests/ConnectionTests.cpp b/API/hermes/inspector/chrome/tests/ConnectionTests.cpp index adcc29d3bd1..fe87ba61e2c 100644 --- a/API/hermes/inspector/chrome/tests/ConnectionTests.cpp +++ b/API/hermes/inspector/chrome/tests/ConnectionTests.cpp @@ -2793,7 +2793,7 @@ TEST_F(ConnectionTests, testConsoleBuffer) { EXPECT_EQ(note.type, "log"); EXPECT_EQ(note.args.size(), 1); received[nthLog % kExpectedMaxBufferSize] = true; - } catch (const std::exception &e) { + } catch (const std::exception &) { EXPECT_EQ(note.type, "warning"); EXPECT_EQ(note.args.size(), 1); EXPECT_NE((*note.args[0].value).find("discarded"), std::string::npos);