Stop storing title in CDPHandler [1/2]

Summary: The `title` field is something that React Native's ConnectionDemux stores in CDPHandler. However, the data is not useful inside CDPHandler so it should be removed.

Reviewed By: mattbfb

Differential Revision: D50954257

fbshipit-source-id: ee590b8347981bf2fa0ad9ec3d824d7a953cf613

Author: dannysu

API/hermes/inspector/chrome/CDPHandler.cpp

@@ -105,14 +105,9 @@ class CDPHandlerImpl : public message::RequestHandler,
                        public debugger::EventObserver,
                        public std::enable_shared_from_this<CDPHandlerImpl> {
  public:
-  CDPHandlerImpl(
-      std::unique_ptr<RuntimeAdapter> adapter,
-      const std::string &title,
-      bool waitForDebugger);
+  CDPHandlerImpl(std::unique_ptr<RuntimeAdapter> adapter, bool waitForDebugger);
   ~CDPHandlerImpl() override;
 
-  std::string getTitle() const;
-
   bool registerCallbacks(
       CDPMessageCallbackFunction msgCallback,
       OnUnregisterFunction onUnregister);
@@ -336,7 +331,6 @@ class CDPHandlerImpl : public message::RequestHandler,
   /// inside the CDP Handler without requiring \p RuntimeAdapter::getRuntime
   /// to support use from arbitrary threads.
   HermesRuntime &runtime_;
-  const std::string title_;
 
   // preparedScripts_ stores user-entered scripts that have been prepared for
   // execution, and may be invoked by a later command.
@@ -428,11 +422,9 @@ class CDPHandlerImpl : public message::RequestHandler,
 
 CDPHandlerImpl::CDPHandlerImpl(
     std::unique_ptr<RuntimeAdapter> adapter,
-    const std::string &title,
     bool waitForDebugger)
     : runtimeAdapter_(std::move(adapter)),
       runtime_(runtimeAdapter_->getRuntime()),
-      title_(title),
       awaitingDebuggerOnStart_(waitForDebugger) {
   // Install __tickleJs. Do this activity before the call to setEventObserver,
   // so we don't get any didPause callback firings for these.
@@ -456,13 +448,6 @@ CDPHandlerImpl::~CDPHandlerImpl() {
   // by other mutex
 }
 
-std::string CDPHandlerImpl::getTitle() const {
-  // This is a public function, but the mutex is not required
-  // as we're just returning member that is unchanged for the
-  // lifetime of this instance.
-  return title_;
-}
-
 bool CDPHandlerImpl::registerCallbacks(
     CDPMessageCallbackFunction msgCallback,
     OnUnregisterFunction onUnregister) {
@@ -1639,6 +1624,14 @@ bool CDPHandlerImpl::validateExecutionContext(
 /*
  * CDPHandler
  */
+std::shared_ptr<CDPHandler> CDPHandler::create(
+    std::unique_ptr<RuntimeAdapter> adapter,
+    bool waitForDebugger) {
+  // Can't use make_shared here since the constructor is private.
+  return std::shared_ptr<CDPHandler>(
+      new CDPHandler(std::move(adapter), "", waitForDebugger));
+}
+
 std::shared_ptr<CDPHandler> CDPHandler::create(
     std::unique_ptr<RuntimeAdapter> adapter,
     const std::string &title,
@@ -1654,15 +1647,15 @@ CDPHandler::CDPHandler(
     bool waitForDebugger)
     : impl_(std::make_shared<CDPHandlerImpl>(
           std::move(adapter),
-          title,
-          waitForDebugger)) {
+          waitForDebugger)),
+      title_(title) {
   impl_->installLogHandler();
 }
 
 CDPHandler::~CDPHandler() = default;
 
 std::string CDPHandler::getTitle() const {
-  return impl_->getTitle();
+  return title_;
 }
 
 bool CDPHandler::registerCallbacks(

API/hermes/inspector/chrome/CDPHandler.h

@@ -53,6 +53,10 @@ class INSPECTOR_EXPORT CDPHandler {
   /// should generally called before you start running any JS in the runtime.
   /// This should also be called on the runtime thread, as methods are invoked
   /// on the given \p adapter.
+  static std::shared_ptr<CDPHandler> create(
+      std::unique_ptr<RuntimeAdapter> adapter,
+      bool waitForDebugger = false);
+  /// Temporarily kept to allow React Native build to still work
   static std::shared_ptr<CDPHandler> create(
       std::unique_ptr<RuntimeAdapter> adapter,
       const std::string &title,
@@ -84,6 +88,7 @@ class INSPECTOR_EXPORT CDPHandler {
 
  private:
   std::shared_ptr<CDPHandlerImpl> impl_;
+  const std::string title_;
 };
 
 } // namespace chrome

API/hermes/inspector/chrome/cli/main.cpp

@@ -132,7 +132,7 @@ static void runScript(const std::string &scriptSource, const std::string &url) {
       std::make_unique<fbhermes::inspector_modern::SharedRuntimeAdapter>(
           runtime);
   std::shared_ptr<CDPHandler> cdpHandler =
-      CDPHandler::create(std::move(adapter), "hermes-chrome-debug-server");
+      CDPHandler::create(std::move(adapter));
   std::thread debuggerLoop(runDebuggerLoop, std::ref(cdpHandler), scriptSource);
 
   fbhermes::HermesRuntime::DebugFlags flags{};

API/hermes/inspector/chrome/tests/SyncConnection.cpp

@@ -35,7 +35,6 @@ SyncConnection::SyncConnection(
     bool waitForDebugger)
     : cdpHandler_(CDPHandler::create(
           std::make_unique<ExecutorRuntimeAdapter>(runtime),
-          "testConn",
           waitForDebugger)) {
   registerCallbacks();
 }