Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.76 Changelog error is wrong about [silence] - should be [declarations] #6572

Closed
lll000111 opened this issue Jul 6, 2018 · 6 comments
Closed

Comments

@lll000111
Copy link
Contributor

lll000111 commented Jul 6, 2018

See #4916 (comment)

It was renamed [declarations] according to the last comments for the PR.

The commit message for 433581b also is wrong, it says [silence] while the actual code says [declarations]

By the way, when this is documented some day I hope there will also be an explanation for the name "declarations". The previous choice "silence" was more or less obvious to anyone, "declarations" requires internal knowledge about "decl mode" that most Flow users are completely unaware of (I never heard about it before reading through the PR discussion). I think it's unfortunate that a naming that exposes internals was chosen, I think one should aim to name things meant for external consumption based on the outside view, not based on what's (well hidden) inside.

@lll000111 lll000111 changed the title 0.76 Changelog error is wrong about [silence] 0.76 Changelog error is wrong about [silence] - should be [declarations] Jul 6, 2018
@vladshcherbin
Copy link

Yep, declarations is a terrible name. Impossible to understand, why it was chosen instead of silence and what it does

@gabelevi
Copy link
Contributor

Ah, sorry, when I put together the Changelog I went based on commit messages. And I think the commit message on the imported diff never got updated when the feature was renamed 😢

@mrkev
Copy link
Contributor

mrkev commented Jul 11, 2018

(yup, myb!)

@sibelius
Copy link

[declarations]
.*/node_modules/.*

declarations is not working for me,

it is still showing errors on node_modules

is this the right way of using declarations?

@lll000111
Copy link
Contributor Author

@sibelius Probably this: #4916 (comment)

@mickdekkers
Copy link

@gabelevi it looks like the changelog in the Releases tab on GitHub still says [silence]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants