-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.76 Changelog error is wrong about [silence] - should be [declarations] #6572
Comments
Yep, declarations is a terrible name. Impossible to understand, why it was chosen instead of silence and what it does |
Ah, sorry, when I put together the Changelog I went based on commit messages. And I think the commit message on the imported diff never got updated when the feature was renamed 😢 |
(yup, myb!) |
[declarations]
.*/node_modules/.* declarations is not working for me, it is still showing errors on node_modules is this the right way of using declarations? |
@sibelius Probably this: #4916 (comment) |
@gabelevi it looks like the changelog in the Releases tab on GitHub still says |
See #4916 (comment)
It was renamed
[declarations]
according to the last comments for the PR.The commit message for 433581b also is wrong, it says [silence] while the actual code says [declarations]
By the way, when this is documented some day I hope there will also be an explanation for the name "declarations". The previous choice "silence" was more or less obvious to anyone, "declarations" requires internal knowledge about "decl mode" that most Flow users are completely unaware of (I never heard about it before reading through the PR discussion). I think it's unfortunate that a naming that exposes internals was chosen, I think one should aim to name things meant for external consumption based on the outside view, not based on what's (well hidden) inside.
The text was updated successfully, but these errors were encountered: