Random crashes on Flipper-Folly iOS

[arnauddorgans]

🐛 Bug Report

Since Xcode 12.5 we have a lot of crashes on our iOS app due to Flipper-Folly.
It happens randomly but a lot of times (every 4 runs)

Assertion failed: (mutex_++ == -Assertion failed: (--mutex_ == -1), function Unlock, file ../src/base/mutex.h, line 219.
1), function Lock, file ../src/base/mutex.h, line 218.
Assertion failed: (--mutex_ == -1), function Lock, file ../src/base/mutex.h, line 218.
CoreSimulator 772.1 - Device: iPhone 12 (64A365D7-0182-4AAB-9E74-FE2890839DB2) - Runtime: iOS 14.5 (18E182) - DeviceType: iPhone 12

Environment

Any iOS versions
Flipper version: 0.94.1 (still crash I 0.96.1)

Podfile:

    $flipperkit_version = '0.94.1'
    pod 'FlipperKit', '~>' + $flipperkit_version, :configuration => 'Debug'
    pod 'FlipperKit/FlipperKitLayoutComponentKitSupport', '~>' + $flipperkit_version, :configuration => 'Debug'
    pod 'FlipperKit/SKIOSNetworkPlugin', '~>' + $flipperkit_version, :configuration => 'Debug'
    pod 'FlipperKit/FlipperKitUserDefaultsPlugin', '~>' + $flipperkit_version, :configuration => 'Debug'
    pod 'Flipper-DoubleConversion', :configuration => 'Debug'
    pod 'Flipper-Folly', :configuration => 'Debug'
    pod 'Flipper-Glog', :configuration => 'Debug'
    pod 'Flipper-PeerTalk', :configuration => 'Debug'
    pod 'Flipper-RSocket', :configuration => 'Debug'
    pod 'CocoaLibEvent', :configuration => 'Debug'
    pod 'boost-for-react-native', :configuration => 'Debug'
    pod 'OpenSSL-Universal', :configuration => 'Debug'
    pod 'CocoaAsyncSocket', :configuration => 'Debug'
    pod 'ComponentKit', :configuration => 'Debug'
    pod 'Yoga', :configuration => 'Debug'
    pod 'YogaKit', :configuration => 'Debug'
    pod 'RenderCore', :configuration => 'Debug'
    pod 'Flipper-Boost-iOSX', :configuration => 'Debug'
    pod 'Flipper-Fmt', :configuration => 'Debug'

[bill350]

Same issue here and another colleague too 😕

[mweststrate]

Does the same thing happens if you run the iOS/Sample project in this repo?

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

[regularberry]

I'm seeing this on Flipper 0.133.1 - @arnauddorgans did you find a solution?

[lblasa]

I’ve found this issue is very intermittent at launch, is this the same case for you @regularberry ?

[regularberry]

Yep, not consistent @lblasa

[arnauddorgans]

I'm seeing this on Flipper 0.133.1 - @arnauddorgans did you find a solution?

No, we don't use flipper anymore due to this issue

[lblasa]

I think the issue itself comes from Glog. The version used for Flipper seems to be quite behind. I'm in the process of updating it so maybe that will finally fix this issue.

[lblasa]

A new version of Flipper-Glog has just been released:
https://cocoapods.org/pods/Flipper-Glog

It is based off from v0.5.0 which is the latest. I believe it may solve the issue.

[regularberry]

I've updated DoubleConversion to 3.2.0 and Glog to 0.5.0.3 and haven't seen this issue pop up yet 🙌 - thanks @lblasa !

[regularberry]

Nevermind, spoke too soon. We see it happen during UI test runs.

[lblasa]

@regularberry I think this may have been properly fixed now. Could you please try the newer Flipper-Glog version?

Flipper-Glog v0.5.0.4

Multi-threading config settings were not properly set.

[regularberry]

@lblasa I'll check it out, thanks for the update!

[regularberry]

@lblasa We haven't seen this issue in a while with the latest Glog 👍 Thanks for fixing this!