From c73270ba4423a83b281f9e35098cb74044831270 Mon Sep 17 00:00:00 2001 From: Harshit Gulati Date: Mon, 6 Jan 2025 22:08:33 -0800 Subject: [PATCH] Allow more time for ports to come up after qsfp service cold boot Summary: We are currently waiting only 1min for ports to come up after cold-booting qsfp service. This is causing flakiness in tests. This was exposed by D67580376 which optimizes waitForAllCabledPorts implementation. Our overall expectation is for services to stablize and ports to come up within 5mins. Matching that in the test too Reviewed By: birdsoup Differential Revision: D67885054 fbshipit-source-id: 35451c263df0076fe74f2519c7ed988dfdb3b6c6 --- fboss/agent/test/link_tests/LinkSanityTests.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fboss/agent/test/link_tests/LinkSanityTests.cpp b/fboss/agent/test/link_tests/LinkSanityTests.cpp index c55da8591e110..6415918436863 100644 --- a/fboss/agent/test/link_tests/LinkSanityTests.cpp +++ b/fboss/agent/test/link_tests/LinkSanityTests.cpp @@ -466,7 +466,7 @@ TEST_F(LinkTest, qsfpColdbootAfterAgentUp) { /* sleep override */ sleep(5); // Assert all cabled ports are up and transceivers have ACTIVE state - EXPECT_NO_THROW(waitForAllCabledPorts(true)); + EXPECT_NO_THROW(waitForAllCabledPorts(true, 60, 5s)); EXPECT_NO_THROW(utility::waitForAllTransceiverStates( true, getCabledTranceivers(), 60, 5s)); });