variation description
'); $variation->save(); - + $parent_fb_product = new \WC_Facebook_Product($variable_product); $facebook_product = new \WC_Facebook_Product($variation, $parent_fb_product); $description = $facebook_product->get_rich_text_description(); @@ -648,21 +639,15 @@ public function test_get_rich_text_description() { $product = WC_Helper_Product::create_simple_product(); $product->set_description('product content description
'); $product->save(); - + $facebook_product = new \WC_Facebook_Product($product); $description = $facebook_product->get_rich_text_description(); $this->assertEquals('product content description
', $description); - // Test 6: Falls back to post excerpt if content is empty and sync_short_description is true - add_option( - WC_Facebookcommerce_Integration::SETTING_PRODUCT_DESCRIPTION_MODE, - WC_Facebookcommerce_Integration::PRODUCT_DESCRIPTION_MODE_SHORT - ); - $product->set_description(''); $product->set_short_description('short description test
'); $product->save(); - + $facebook_product = new \WC_Facebook_Product($product); $description = $facebook_product->get_rich_text_description(); $this->assertEquals('short description test
', $description); @@ -671,10 +656,10 @@ public function test_get_rich_text_description() { add_filter('facebook_for_woocommerce_fb_rich_text_description', function($description) { return 'filtered description
'; }); - + $description = $facebook_product->get_rich_text_description(); $this->assertEquals('filtered description
', $description); - + // Cleanup remove_all_filters('facebook_for_woocommerce_fb_rich_text_description'); delete_option(WC_Facebookcommerce_Integration::SETTING_PRODUCT_DESCRIPTION_MODE); @@ -710,7 +695,7 @@ public function test_rich_text_description_html_preservation() { $facebook_product->set_rich_text_description($html_content); $description = $facebook_product->get_rich_text_description(); - + // Test HTML structure is preserved $this->assertStringContainsString('fallback description
'); $description = $facebook_product->get_rich_text_description(); $this->assertEquals('fallback description
', $description); - + // Test behavior when both rich_text_description and post meta are empty delete_post_meta($product->get_id(), \WC_Facebook_Product::FB_RICH_TEXT_DESCRIPTION); $description = $facebook_product->get_rich_text_description(); @@ -751,36 +736,36 @@ public function test_rich_text_description_variants() { // Create variable product with variation $variable_product = WC_Helper_Product::create_variation_product(); $variation = wc_get_product($variable_product->get_children()[0]); - + // Set up parent product $parent_fb_product = new \WC_Facebook_Product($variable_product); - + // Set the rich text description using post meta for the parent update_post_meta($variable_product->get_id(), \WC_Facebook_Product::FB_RICH_TEXT_DESCRIPTION, 'parent rich text
'); - + // Test 1: Variation inherits parent's rich text description when empty $facebook_product = new \WC_Facebook_Product($variation, $parent_fb_product); $description = $facebook_product->get_rich_text_description(); $this->assertEquals('parent rich text
', $description); - + // Test 2: Variation uses its own rich text description when set $variation_fb_product = new \WC_Facebook_Product($variation, $parent_fb_product); $variation_fb_product->set_rich_text_description('variation rich text
'); $description = $variation_fb_product->get_rich_text_description(); $this->assertEquals('variation rich text
', $description); - + // // Test 3: Variation uses its post meta when set // update_post_meta($variation->get_id(), \WC_Facebook_Product::FB_RICH_TEXT_DESCRIPTION, 'variation meta rich text
'); // $new_variation_product = new \WC_Facebook_Product($variation, $parent_fb_product); // $description = $new_variation_product->get_rich_text_description(); // $this->assertEquals('variation meta rich text
', $description); - + // Test 4: Fallback chain for variations delete_post_meta($variation->get_id(), \WC_Facebook_Product::FB_RICH_TEXT_DESCRIPTION); } /** - * Test Brand is added for simple product + * Test Brand is added for simple product * @return void */ public function test_brand_for_simple_product_set() { @@ -796,7 +781,7 @@ public function test_brand_for_simple_product_set() { } /** - * Test MPN is added for simple product + * Test MPN is added for simple product * @return void */ public function test_mpn_for_simple_product_set() { @@ -812,7 +797,7 @@ public function test_mpn_for_simple_product_set() { } /** - * Test MPN is added for variable product + * Test MPN is added for variable product * @return void */ public function test_mpn_for_variable_product_set() { @@ -836,10 +821,10 @@ public function test_get_fb_brand_variable_products() { // Create a variable product and set the brand for the parent $variable_product = WC_Helper_Product::create_variation_product(); $facebook_product_parent = new \WC_Facebook_Product($variable_product); - + // Set brand for parent product update_post_meta($variable_product->get_id(), \WC_Facebook_Product::FB_BRAND, 'Nike'); - + // Get the variation product $variation = wc_get_product($variable_product->get_children()[0]); @@ -867,7 +852,7 @@ public function test_get_fb_brand_variable_products() { private function create_product_attribute($name, $value, $is_taxonomy) { $attribute = new \WC_Product_Attribute(); $attribute->set_id(0); - + // Handle attribute names with spaces if ($is_taxonomy) { $name = strtolower(str_replace(' ', '-', $name)); @@ -875,15 +860,15 @@ private function create_product_attribute($name, $value, $is_taxonomy) { } else { $attribute->set_name($name); } - + if ($is_taxonomy) { // For taxonomy attributes $values = is_array($value) ? $value : [$value]; $term_ids = []; - + foreach ($values as $term_value) { $taxonomy = $attribute->get_name(); - + // Create the taxonomy if it doesn't exist if (!taxonomy_exists($taxonomy)) { register_taxonomy( @@ -897,7 +882,7 @@ private function create_product_attribute($name, $value, $is_taxonomy) { ] ); } - + // Create and get the term $term = wp_insert_term($term_value, $taxonomy); if (!is_wp_error($term)) { @@ -912,11 +897,11 @@ private function create_product_attribute($name, $value, $is_taxonomy) { $attribute->set_options($values); $attribute->is_taxonomy(false); } - + $attribute->set_position(0); $attribute->set_visible(1); $attribute->set_variation(0); - + return $attribute; } @@ -934,7 +919,7 @@ private function process_attributes_and_verify($product, $input_attributes, $exp ); $attributes[] = $attribute; } - + $product->set_attributes($attributes); $product->save(); @@ -968,14 +953,14 @@ private function verify_saved_meta_values($product_id, $expected_output) { foreach ($meta_key_map as $field => $meta_key) { $saved_value = get_post_meta($product_id, $meta_key, true); - + if (!empty($expected_output[$field])) { // Get term name if it's a taxonomy term ID if (is_numeric($saved_value)) { $term = get_term($saved_value); $saved_value = $term ? $term->name : $saved_value; } - + $this->assertEquals( $expected_output[$field], $saved_value, @@ -1056,59 +1041,128 @@ public function test_external_update_time_unset() { $this->assertEquals(isset($data['external_update_time']), false); } + /** + * Test fallback to main description when it's less than 1000 characters. + */ + public function test_get_fb_short_description_fallback_to_short_main_description() { + // Arrange + $product = WC_Helper_Product::create_simple_product(); + $short_description = 'Short main description'; + // Set up the test conditions + $product->set_description($short_description); + $product->set_short_description(''); // Ensure short description is empty + $product->save(); + + // Act + $facebook_product = new \WC_Facebook_Product($product); + $result_description = $facebook_product->get_fb_short_description(); + + // Assert + $this->assertEquals( + $short_description, + $result_description, + 'Short main description should be used when excerpt is empty' + ); + } /** - * Tests for get_fb_short_description() method + * Test fallback to main description when it's exactly 1000 characters. */ - public function test_get_fb_short_description() { - // Test 1: Variation products should inherit parent's short description - $variable_product = WC_Helper_Product::create_variation_product(); - $variation = wc_get_product($variable_product->get_children()[0]); - - // Set the parent product's short description - $variable_product->set_short_description('parent short description'); - $variable_product->save(); - - // Even if we try to set a short description on the variation (which we dont have functionality for in WooCommerce UI) - $variation->set_short_description('variation short description - should be ignored'); - $variation->save(); - - $parent_fb_product = new \WC_Facebook_Product($variable_product); - $facebook_product = new \WC_Facebook_Product($variation, $parent_fb_product); - $description = $facebook_product->get_fb_short_description(); - - // Variations should inherit the parent product's short description - $this->assertEquals('parent short description', $description, 'Variations should inherit parent short description'); - - // Test 2: Gets short description from post excerpt for simple products + public function test_get_fb_short_description_fallback_to_exact_length_main_description() { + // Arrange $product = WC_Helper_Product::create_simple_product(); - $product->set_short_description('product short description'); - $product->save(); + $exact_length_description = str_repeat('a', 1000); + // Set up the test conditions + $product->set_description($exact_length_description); + $product->set_short_description(''); // Ensure short description is empty + $product->save(); + + // Act $facebook_product = new \WC_Facebook_Product($product); - $description = $facebook_product->get_fb_short_description(); - $this->assertEquals('product short description', $description); - - // Test 3: Returns empty string when no short description exists + $result_description = $facebook_product->get_fb_short_description(); + + // Assert + $this->assertEquals( + $exact_length_description, + $result_description, + 'Main description of exactly 1000 characters should be used when excerpt is empty' + ); + $this->assertEquals( + 1000, + strlen($result_description), + 'Result description should be exactly 1000 characters long' + ); + } + + /** + * Test that main description is not used when it exceeds 1000 characters. + */ + public function test_get_fb_short_description_no_fallback_to_long_main_description() { + // Arrange $product = WC_Helper_Product::create_simple_product(); - $product->set_short_description(''); - $product->save(); + $too_long_description = str_repeat('a', 1001); + // Set up the test conditions + $product->set_description($too_long_description); + $product->set_short_description(''); // Ensure short description is empty + $product->save(); + + // Act $facebook_product = new \WC_Facebook_Product($product); - $description = $facebook_product->get_fb_short_description(); - $this->assertEquals('', $description); - - // Test 4: Applies filters - $filter = $this->add_filter_with_safe_teardown('facebook_for_woocommerce_fb_product_short_description', function($description, $id) { - return 'filtered short description for product ' . $id; - }, 10, 2); + $result_description = $facebook_product->get_fb_short_description(); + + // Assert + $this->assertEquals( + '', + $result_description, + 'Should not fallback to main description if it exceeds 1000 characters' + ); + $this->assertNotEquals( + $too_long_description, + $result_description, + 'Long description should not be used even if no other description is available' + ); + $this->assertLessThan( + strlen($too_long_description), + strlen($result_description), + 'Result description should be shorter than the too-long main description' + ); + } + + /** + * Test that short description is always preferred over main description, even when both are present + * and main description is short enough to be used. + */ + public function test_get_fb_short_description_prefers_short_over_main() { + // Arrange + $product = WC_Helper_Product::create_simple_product(); + $short_description = 'Short product description'; + $main_description = 'Main product description that is also short'; - $description = $facebook_product->get_fb_short_description(); - $this->assertEquals('filtered short description for product ' . $product->get_id(), $description); + // Set up both descriptions + $product->set_description($main_description); + $product->set_short_description($short_description); + $product->save(); + + // Act + $facebook_product = new \WC_Facebook_Product($product); + $result_description = $facebook_product->get_fb_short_description(); + + // Assert + $this->assertEquals( + $short_description, + $result_description, + 'Short description should be used when available, regardless of main description length' + ); - // Remove the filter early - $filter->teardown_safely_immediately(); + // Verify we're not using the main description + $this->assertNotEquals( + $main_description, + $result_description, + 'Main description should not be used when short description is available' + ); } /** @@ -1117,7 +1171,7 @@ public function test_get_fb_short_description() { public function test_get_unmapped_attributes_no_attributes() { $product = WC_Helper_Product::create_simple_product(); $facebook_product = new \WC_Facebook_Product($product); - + $unmapped_attributes = $facebook_product->get_unmapped_attributes(); $this->assertIsArray($unmapped_attributes); $this->assertEmpty($unmapped_attributes); @@ -1128,7 +1182,7 @@ public function test_get_unmapped_attributes_no_attributes() { */ public function test_get_unmapped_attributes_only_mapped() { $product = WC_Helper_Product::create_simple_product(); - + // Add mapped attributes (size, color) $attributes = array(); $attributes[] = $this->create_product_attribute('size', 'Large', false); @@ -1138,7 +1192,7 @@ public function test_get_unmapped_attributes_only_mapped() { $facebook_product = new \WC_Facebook_Product($product); $unmapped_attributes = $facebook_product->get_unmapped_attributes(); - + $this->assertIsArray($unmapped_attributes); $this->assertEmpty($unmapped_attributes); } @@ -1148,7 +1202,7 @@ public function test_get_unmapped_attributes_only_mapped() { */ public function test_get_unmapped_attributes_only_unmapped() { $product = WC_Helper_Product::create_simple_product(); - + // Add unmapped attributes $attributes = array(); $attributes[] = $this->create_product_attribute('weight', '2kg', false); @@ -1158,14 +1212,14 @@ public function test_get_unmapped_attributes_only_unmapped() { $facebook_product = new \WC_Facebook_Product($product); $unmapped_attributes = $facebook_product->get_unmapped_attributes(); - + $this->assertIsArray($unmapped_attributes); $this->assertCount(2, $unmapped_attributes); - + // Verify first unmapped attribute $this->assertEquals('weight', $unmapped_attributes[0]['name']); $this->assertEquals('2kg', $unmapped_attributes[0]['value']); - + // Verify second unmapped attribute $this->assertEquals('style', $unmapped_attributes[1]['name']); $this->assertEquals('Modern', $unmapped_attributes[1]['value']); @@ -1176,7 +1230,7 @@ public function test_get_unmapped_attributes_only_unmapped() { */ public function test_get_unmapped_attributes_mixed() { $product = WC_Helper_Product::create_simple_product(); - + // Add both mapped and unmapped attributes $attributes = array(); $attributes[] = $this->create_product_attribute('size', 'Medium', false); // mapped @@ -1188,10 +1242,10 @@ public function test_get_unmapped_attributes_mixed() { $facebook_product = new \WC_Facebook_Product($product); $unmapped_attributes = $facebook_product->get_unmapped_attributes(); - + $this->assertIsArray($unmapped_attributes); $this->assertCount(2, $unmapped_attributes); - + // Verify only unmapped attributes are returned $this->assertEquals('weight', $unmapped_attributes[0]['name']); $this->assertEquals('3kg', $unmapped_attributes[0]['value']); @@ -1204,7 +1258,7 @@ public function test_get_unmapped_attributes_mixed() { */ public function test_get_unmapped_attributes_empty_values() { $product = WC_Helper_Product::create_simple_product(); - + // Add attributes with empty values $attributes = array(); $attributes[] = $this->create_product_attribute('weight', '', false); // empty unmapped @@ -1215,10 +1269,10 @@ public function test_get_unmapped_attributes_empty_values() { $facebook_product = new \WC_Facebook_Product($product); $unmapped_attributes = $facebook_product->get_unmapped_attributes(); - + $this->assertIsArray($unmapped_attributes); $this->assertCount(1, $unmapped_attributes); - + // Verify only non-empty unmapped attribute is returned $this->assertEquals('style', $unmapped_attributes[0]['name']); $this->assertEquals('Modern', $unmapped_attributes[0]['value']);