diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f5ba763a0..7bedc5686 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,16 +8,19 @@ List any dependencies that are required for this change. Please delete options that are not relevant. -- [ ] Bug fix (non-breaking change which fixes an issue) -- [ ] New feature (non-breaking change which adds functionality) -- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) +- Bug fix (non-breaking change which fixes an issue) +- New feature (non-breaking change which adds functionality) +- Syntax change (non-breaking change which fixes code modularity, linting or phpcs issues) +- Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist -- [ ] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) -- [ ] I have commented my code, particularly in hard-to-understand areas -- [ ] I have added tests and all the new and existing unit tests pass locally with my changes -- [ ] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. +- [] I have commented my code, particularly in hard-to-understand areas. +- [] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. +- [] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). +- [] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. +- [] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. +- [] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). ## Changelog entry