From a6a92b55d46eb6ee16cc8f6fb033e514c5113d9b Mon Sep 17 00:00:00 2001 From: Paul Kang Date: Wed, 5 Mar 2025 13:02:07 -0800 Subject: [PATCH 1/2] Reverting a lint fix which defined dynamic variables --- includes/Framework/Utilities/AsyncRequest.php | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/includes/Framework/Utilities/AsyncRequest.php b/includes/Framework/Utilities/AsyncRequest.php index b29a96ec8..b759be0ed 100644 --- a/includes/Framework/Utilities/AsyncRequest.php +++ b/includes/Framework/Utilities/AsyncRequest.php @@ -35,16 +35,6 @@ abstract class AsyncRequest { /** @var array request data */ protected $data = []; - /** @var array query arguments */ - protected $query_args; - - /** @var string query URL */ - protected $query_url; - - /** @var array request arguments */ - protected $request_args; - - /** * Initiate a new async request * From f32c5d12295bddce011cf1a89153ff4e331d58e2 Mon Sep 17 00:00:00 2001 From: Paul Kang Date: Wed, 5 Mar 2025 13:04:03 -0800 Subject: [PATCH 2/2] adding lint ignore logic --- includes/Framework/Utilities/AsyncRequest.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/includes/Framework/Utilities/AsyncRequest.php b/includes/Framework/Utilities/AsyncRequest.php index b759be0ed..17f6d3119 100644 --- a/includes/Framework/Utilities/AsyncRequest.php +++ b/includes/Framework/Utilities/AsyncRequest.php @@ -87,6 +87,8 @@ protected function get_query_args() { // Check if a child class has defined this property for custom query args if ( property_exists( $this, 'query_args' ) ) { + // Dynamic property; not defined in the parent class, and not a true lint error + // phpcs:ignore return $this->query_args; } @@ -107,6 +109,8 @@ protected function get_query_url() { // Check if a child class has defined this property for a custom URL if ( property_exists( $this, 'query_url' ) ) { + // Dynamic property; not defined in the parent class, and not a true lint error + // phpcs:ignore return $this->query_url; } @@ -126,6 +130,8 @@ protected function get_request_args() { // Check if a child class has defined this property for custom request args if ( property_exists( $this, 'request_args' ) ) { + // Dynamic property; not defined in the parent class, and not a true lint error + // phpcs:ignore return $this->request_args; }