Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up Text and Hashable constraints #730

Open
L0neGamer opened this issue Feb 5, 2024 · 0 comments
Open

Up Text and Hashable constraints #730

L0neGamer opened this issue Feb 5, 2024 · 0 comments

Comments

@L0neGamer
Copy link

In #724 I bump aeson and make it work across versions.

It would be good if duckling can update the constraints on Text and Hashable so it works on a modern version of GHC.

for hashable, one merely needs to add the following to Duckling.Types:

-- Eq
instance Eq (Dimension a) where
  (==) a b = hash a == hash b

For Text there are more detailed changes needed, as Text switches from UTF-16 to UTF-8, and Duckling uses internals functions to manipulate Texts.

Suggested new bounds are hashable >= 1.2.4.0 && < 1.5 and text >= 2 && < 2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant