Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump react-json-view package version to remove peer-dep issue with Re… #9494

Closed
wants to merge 1 commit into from

Conversation

homotechsual
Copy link
Contributor

@homotechsual homotechsual commented Nov 1, 2023

…act 18

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

#9486

Copy link

netlify bot commented Nov 1, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 5c42285
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/654292322c551900083208ea
😎 Deploy Preview https://deploy-preview-9494--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 1, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 68 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/installation 🟠 60 🟢 98 🟢 100 🟢 100 🟠 89 Report
/docs/category/getting-started 🟠 71 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog 🟠 89 🟢 100 🟢 100 🟢 90 🟠 89 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 75 🟢 97 🟢 100 🟢 100 🟠 89 Report
/blog/tags/release 🟠 65 🟢 100 🟢 100 🟠 80 🟠 89 Report
/blog/tags 🟢 91 🟢 100 🟢 100 🟢 90 🟠 89 Report

@yanni4night
Copy link

Expected to merge ASAP

@slorber
Copy link
Collaborator

slorber commented Nov 10, 2023

@homotechsual I could merge but I'm not sure it would solve #9486 ?

The problem is not in the dependency itself but in a transitive dependency flux

@homotechsual
Copy link
Contributor Author

Ah yeah ok - they bumped their node version requirement but that won't alter the flux transitive dep. Looks like we'll need a replacement JSON viewer for the debug plugin?

@mcrstudio
Copy link
Contributor

I think we're good to close this PR in favour of #9566

@slorber slorber closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants