-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Docusaurus v3 upgrades and require TypeScript 5 #9258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: breaking change
Existing sites may not build successfully in the new version. Description contains more details.
label
Aug 25, 2023
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
slorber
added
the
Argos
Add this label to run UI visual regression tests. See argos.yml GH action.
label
Aug 25, 2023
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
This was referenced Oct 19, 2023
This was referenced Jun 14, 2024
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Argos
Add this label to run UI visual regression tests. See argos.yml GH action.
CLA Signed
Signed Facebook CLA
pr: breaking change
Existing sites may not build successfully in the new version. Description contains more details.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
TypeScript 5 is now required for Docusaurus v3
Motivation
Handle #9050 (review), use these settings for client code packaging:
"bundler" is a new TS 5.0 option: https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#moduleresolution-bundler
This also fix our setup for TypeScript 5.2 because this version introduces new errors that makes it impossible to:
Test Plan
CI
Deploy preview: https://deploy-preview-9258--docusaurus-2.netlify.app/