chore(v2): TypeScript, use isolatedModules #4790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: maintenance
|
[V1] Built with commit ad3cf6a |
|
[V2] Built with commit ad3cf6a |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4790--docusaurus-2.netlify.app/ |
|
Size Change: +6.94 kB (+1%) Total Size: 640 kB
ℹ️ View Unchanged
|
slorber
commented
May 14, 2021
| // Re-expose useDocs | ||
| // Ensure it's always statically available even if user is not using the docs plugin | ||
| // Problem reported for the blog-only mode: https://github.com/facebook/docusaurus/issues/3360 | ||
| export * from '@docusaurus/plugin-content-docs/src/theme/hooks/useDocs'; |
There was a problem hiding this comment.
@SamChou19815 this change can affect the blog-only mode, the e2e test pass and it looks it keeps working, let me know if you see any issue on next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's safer to ensure that TS files can be transpiled independently.
Ie, transpiled by other tools like Babel or esbuild.
We use esbuild-loader in #4765 on the Docusaurus website now, and it is a recommended option