From 917c8ac81b7b953988f30b187b6d5ed77ab55588 Mon Sep 17 00:00:00 2001 From: Sean Zhu Date: Thu, 10 Oct 2019 01:56:31 -0700 Subject: [PATCH 1/2] Update index.js --- packages/eslint-config-react-app/index.js | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/eslint-config-react-app/index.js b/packages/eslint-config-react-app/index.js index 419dc10e8d4..b0e3fb1449f 100644 --- a/packages/eslint-config-react-app/index.js +++ b/packages/eslint-config-react-app/index.js @@ -81,7 +81,6 @@ module.exports = { '@typescript-eslint/consistent-type-assertions': 'warn', 'no-array-constructor': 'off', '@typescript-eslint/no-array-constructor': 'warn', - '@typescript-eslint/no-namespace': 'error', 'no-use-before-define': 'off', '@typescript-eslint/no-use-before-define': [ 'warn', From eb791d84676b4543f672cbb61783df0dfd1b6e4b Mon Sep 17 00:00:00 2001 From: Alex Guerra Date: Tue, 12 Nov 2019 14:23:42 -0600 Subject: [PATCH 2/2] Add declare namespace to typescript test --- test/fixtures/typescript/src/App.ts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/test/fixtures/typescript/src/App.ts b/test/fixtures/typescript/src/App.ts index 665f8b49f1f..ee9276a699a 100644 --- a/test/fixtures/typescript/src/App.ts +++ b/test/fixtures/typescript/src/App.ts @@ -27,4 +27,11 @@ function propertyDecorator(target: any, key: string) { }; } +declare namespace MyNamespace { + interface MyType { + foo: string; + bar: (n: number) => void; + } +} + export default App;