Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eslintConfig from package.json #649

Merged
merged 1 commit into from
Sep 14, 2016
+1 −9
Merged

Remove eslintConfig from package.json #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions scripts/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,6 @@ module.exports = function(appPath, appName, verbose, originalDirectory) {
'eject': 'react-scripts eject'
};

// explicitly specify ESLint config path for editor plugins
appPackage.eslintConfig = {
extends: './node_modules/react-scripts/config/eslint.js',
};

fs.writeFileSync(
path.join(appPath, 'package.json'),
JSON.stringify(appPackage, null, 2)
Expand Down
5 changes: 1 addition & 4 deletions template/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ You would need to install an ESLint plugin for your editor first.

><img src="http://i.imgur.com/yVNNHJM.png" width="300">

Then make sure `package.json` of your project ends with this block:
Then add this block to the `package.json` file of your project:

```js
{
Expand All @@ -168,9 +168,6 @@ Then make sure `package.json` of your project ends with this block:
}
```

Projects generated with `[email protected]` and higher should already have it.
If you don’t need ESLint integration with your editor, you can safely delete those three lines from your `package.json`.

Finally, you will need to install some packages *globally*:

```sh
Expand Down