-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for WebWorker with worker-loader (#3660) #3934
Conversation
This looks good to be merged. I hope we can use this soon to fix janks 👍 |
Awesome. Looking forward to this getting merged! |
Nice! Might be helpful to include notes on use-case, including limitations. As examples,
These are questions I have, at least. |
Cool, the changes work in my current project perfectly @iansu, looking forward to this being merged |
@@ -213,6 +213,32 @@ module.exports = { | |||
name: 'static/media/[name].[hash:8].[ext]', | |||
}, | |||
}, | |||
// Process WebWorkder JS with Babel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo. WebWorkers
What is holding this back? Seems like a beautiful solution. |
If there are any loose ends (documentation, etc), I’d be happy to help! Really wanna try this out |
Nice feature. It did exactly what i needed. By the way: Would be great to have something like a workerTransform to be able to test web workers in their surrounding with jest. I have not much experience with webpack, babel and jest but i build some simple dirty stuff: Maybe you could use it to get an idea of what i mean. |
Waiting for this also 🤞 |
Looking forward to having this PR resolved and merged 🥇 |
Use
worker-loader
to turn any file that ends with.worker.js
into a WebWorker.Closes #3660
Here is the sample WebWorker code I used to test this: