Skip to content

Update doc server example to work from any directory #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Timer merged 2 commits into from
Apr 19, 2017
+4 −4
Merged

Update doc server example to work from any directory #1988

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebdb646
Node.js serving with absolute path
isramos Apr 17, 2017
a418a24
Update README.md
Timer Apr 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-scripts/template/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1242,7 +1242,7 @@ const express = require('express');
const path = require('path');
const app = express();

app.use(express.static('./build'));
app.use(express.static(path.join(__dirname, 'build')))

app.get('/', function (req, res) {
res.sendFile(path.join(__dirname, './build', 'index.html'));

@Timer Timer Apr 17, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this code was already here, but is the ./ for ./build required, or worse, mess anything up?

Expand Down