Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolveOwn in config/paths.js is undefined after running eject #973

Closed
0x80 opened this issue Oct 27, 2016 · 7 comments
Closed

resolveOwn in config/paths.js is undefined after running eject #973

0x80 opened this issue Oct 27, 2016 · 7 comments

Comments

@0x80
Copy link

0x80 commented Oct 27, 2016

I ran npm run eject and looked at config/paths.js to find linting errors about resolveOwn being undefined

@gaearon
Copy link
Contributor

gaearon commented Oct 28, 2016

I think we need to move this line at the end of the file. Would you like to send a PR?

@EnoahNetzach
Copy link
Contributor

@gaearon I'm doing this ;)

@timoxley
Copy link

Probably means the create-react-app test suite should run the linter on a freshly ejected app.

@gaearon
Copy link
Contributor

gaearon commented Nov 20, 2016

@timoxley Send a PR?

@gaearon
Copy link
Contributor

gaearon commented Nov 20, 2016

Fixed via #978.

@gaearon gaearon closed this as completed Nov 20, 2016
@loopmode
Copy link

Does it mean that, without having the fix applied, we can safely remove the part that uses resolveOwn from the ejected paths.js?

// config before publish: we're in ./packages/react-scripts/config/
if (__dirname.indexOf(path.join('packages', 'react-scripts', 'config')) !== -1) {
    appBuild: resolveOwn('../../../build'),
    ...

@gaearon
Copy link
Contributor

gaearon commented Feb 24, 2017

Does it mean that, without having the fix applied, we can safely remove the part that uses resolveOwn from the ejected paths.js?

Yes

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants