Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App doesn't work in MS Edge (problem with spread operator) #9288

Closed
GendelfLugansk opened this issue Jul 10, 2020 · 1 comment
Closed

App doesn't work in MS Edge (problem with spread operator) #9288

GendelfLugansk opened this issue Jul 10, 2020 · 1 comment

Comments

@GendelfLugansk
Copy link

GendelfLugansk commented Jul 10, 2020

Describe the bug

New app does not work in Microsoft Edge (Microsoft Edge 44.18362.449.0). This looks similar to #8484 but for me production build does not work as well. Also, it is said to be fixed in 3.4.0 but I'm observing this error in 3.4.1

Environment

Environment Info:

  current version of create-react-app: 3.4.1
  running from /home/gennady/.config/yarn/global/node_modules/create-react-app

  System:
    OS: Linux 4.15 Ubuntu 18.04.4 LTS (Bionic Beaver)
    CPU: (12) x64 Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz
  Binaries:
    Node: 14.0.0 - ~/.nvm/versions/node/v14.0.0/bin/node
    Yarn: 1.22.4 - /usr/bin/yarn
    npm: 6.14.4 - ~/.nvm/versions/node/v14.0.0/bin/npm
  Browsers:
    Chrome: 83.0.4103.116
    Firefox: 78.0.1
  npmPackages:
    react: ^16.13.1 => 16.13.1 
    react-dom: ^16.13.1 => 16.13.1 
    react-scripts: 3.4.1 => 3.4.1 
  npmGlobalPackages:
    create-react-app: Not Found

Steps to reproduce

  1. Create new app with npx create-react-app my-app
  2. In src/App.js, change function App() { to function App({...rest}) {
  3. Try to open in MS Edge

Expected behavior

Gray screen with React logo and Edit src/App.js and save to reload. line (the same as I see in Chromium)

Actual behavior

White screen with error SCRIPT1028: SCRIPT1028: Expected identifier, string or number in console. Error points to line with spread operator

@GendelfLugansk
Copy link
Author

GendelfLugansk commented Jul 10, 2020

Workaround

For me everything seems to be working after downgrade to "react-scripts": "3.0.0"

After few experiments I found out that changing browserlist to

"browserslist": [
    ">0.2%",
    "not dead",
    "not op_mini all"
  ]

and running rm -rf node_modules/ && yarn install fixes issue without having to downgrade react-scripts. Just changing browserlist without reinstall does not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant