Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript template dependencies #9095

Open
yonathan06 opened this issue Jun 1, 2020 · 1 comment
Open

Typescript template dependencies #9095

yonathan06 opened this issue Jun 1, 2020 · 1 comment

Comments

@yonathan06
Copy link

I saw that using cra with typescript template adds the dev dependencies to the dependencies property in package.json instead of devdepdencies
I see it here: packages/cra-template-typescript/template.json

Any reason for that?
Is it possible to move it to devdependencies or will it break something?

@yonathan06
Copy link
Author

@JackRKelly If I understand this answer correctly it is ment for module authors, but I believe cra is mostly used for just creating react apps, not for modules. Maybe there should be a different template for creating a react module with typescript.
Also, the comment you posted is right for when you create plain typescript modules, but usually you compile your typescript code before publishing to NPM (or any other package manager), so the package it self is usually JS files with types in *.d.ts, for those who use typescript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant