Run linting in continuous integration

[excitement-engineer]

I am wondering if it is possible to perform an eslint check during continuous integration to ensure that the coding guidelines are maintained by developers.

Does anyone know of a way to do this?

[excitement-engineer]

Specifically for the javascript code. I want CI to be able to catch the warnings in the linter such as the following example:

Do you know if this is currently possible?

[mxstbr]

Sorry, deleted my comment, my brain was still in the wrong project so it didn't make any sense. 😊

I haven't done that so I'm not sure, sorry!

[excitement-engineer]

hahaha no worries!

[gaearon]

I think linting should be a part of npm run build on CI environments.
There is an issue for this: #440.

Would you like to send a PR?
Let's enable this only if process.env.CI is "true".
Otherwise local builds will be annoyingly slow.

It's fine to totally abort the build on CI if there are any lint warnings, but not locally.

[excitement-engineer]

Yes I will send a PR, I will try to find some time to fix this next week:) Thanks a lot for your help and quick response!

[karlhorky]

Can this be closed now that #944 is merged?

[mxstbr]

Yes! Thanks @karlhorky

[karlhorky]

Np, thanks for all the work on this!