-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why should .env
files be checked into source control
#8836
Comments
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
This issue has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. |
🦗 😢 |
@mlodato517 |
Hi @Louies89! Thanks for responding :-) I did link that issue in my original question and I don't think it exactly answers the question. It mentions that:
But just because something doesn't have secrets doesn't necessarily mean it should be checked into source control (I don't think) just that it can be checked into source control. Same thing for env variables affecting build time - those can also be set on machines responsible for building bundles. On the other side I've been given advice to the contrary - that env files should not be checked in. One site that mentions this is 12factor.net but other devs on my team also mentioned that environment variables should be declared by ... the environment ... not by a different set of files checked into source control. I'm not super aware of the downsides of checking in |
@mlodato517 I am aware of that, when I saw the statement, I was also socked. |
I'm not sure I understand what you mean.
This, of course, makes perfect sense
This doesn't seem super clear to me. Also, when you say
which statement are you referring to? |
This is sort of a continuation of #2560 and a new-visibility avenue for this spectrum question.
Basically, why do the docs say
? I can definitely see saying "
.env
files can be safely checked into source control" or something but I'm interested in the position of "they should be checked in". The only thing I can think of is "it's convenient for sharing environment variables between dev" (which is fine! But feels different than the given guidance).Paste of important bits of Spectrum question
The text was updated successfully, but these errors were encountered: