Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-var eslint rule #742

Closed
kasperpeulen opened this issue Sep 24, 2016 · 1 comment
Closed

no-var eslint rule #742

kasperpeulen opened this issue Sep 24, 2016 · 1 comment

Comments

@kasperpeulen
Copy link
Contributor

Just wondering, any particular reason why this rule is not enabled? I thought this is seen as good practice nowadays:

http://eslint.org/docs/rules/no-var

@gaearon
Copy link
Contributor

gaearon commented Sep 24, 2016

It is a bit too opinionated. We only enable lint rules that often result in errors because we show lint warnings “in your face”. Beginners who copy and paste React snippets from StackOverflow and blogs shouldn’t get 50 warnings lecturing them about var because they’re just trying to learn React at this point.

We will likely re-evaluate this decision some time down the road, but now is too early in my opinion. Even our own docs use var in many places.

@gaearon gaearon closed this as completed Sep 24, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants