react-error-overlay dark theme

[William-Owen]

As the tech is increasingly moving over to dark themes; is it possible to get the react-error-overlay to show runtime errors in a dark theme, or possibly making it an option?

Working at night on an application that has a dark theme on my dark themed IDE running on my dark theme OS I find when I cause a runtime error not only am I sad because of the runtime error but also I am sad as I am now blind; which makes solving the error more challenging.

[iansu]

We're not necessarily opposed to this idea, as long as it's unobtrusive (for example by using the prefers-color-scheme: dark media query). However, the only way this is going to happen is if someone from the community does the work and sends in a PR. Is this something you want to work on?

[kostia-lev]

What is preferred way to do it? via command line parameter: default: white, --dark-error - dark?

[iansu]

No, we specifically don't want to add any kind of parameter or config to enable this. The prefers-color-scheme: dark media query is set automatically based on their OS colour scheme so that's what we should use.

[nartoland]

Ok

[Fabianopb]

Hi, this looks like a fun issue to work on. Is someone already doing it?
If not I'd like to grab!
Cheers!

[iansu]

@Fabianopb It's all yours!

[kostia-lev]

interestingly, how to develop anything in packages/react-error-overlay folder? any instruction or helpful links?

[Nufflee]

Any updates on this issue? @Fabianopb

[Fabianopb]

I've had a busy beginning of month, but the work is half way through, I'll get back to it during the weekend!

[Fabianopb]

Just created the PR 🚀

[Nufflee]

That was really fast, thanks! Can't wait to try it out.

[William-Owen]

Fantastic thank you Fabianopb!