Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange configuration of eslint-config-react-app #6115

Closed
adam-golab opened this issue Jan 3, 2019 · 7 comments
Closed

Strange configuration of eslint-config-react-app #6115

adam-golab opened this issue Jan 3, 2019 · 7 comments

Comments

@adam-golab
Copy link

Could someone explain to me what's going on with this hardcoded version (999.999.999)? It looks like there may be some errors in the future caused by the wrong version.

settings: { react: { version: '999.999.999' } },

@mrmckeb
Copy link
Contributor

mrmckeb commented Jan 4, 2019

Good question @adam-golab, I'm not sure. Perhaps @Timer can answer this one?

@existentialism
Copy link
Contributor

existentialism commented Jan 4, 2019

Check out: #5043

@ianschmitz
Copy link
Contributor

If we bump eslint-plugin-react to 7.12.0, we can use detect as the value instead.

@Timer
Copy link
Contributor

Timer commented Jan 7, 2019

tl;dr newer versions of eslint-plugin-react required you specified a React version. The old behavior was to always lint as if React was the latest version.

Due to the logic on eslint-plugin-react, the only way to tell it to always lint as if it was the latest version of React was an arbitrary high version.

@konekoya
Copy link

konekoya commented Jan 7, 2019

@Timer it would be great if you guys can leave a comment around that number :)

@ianschmitz
Copy link
Contributor

@konekoya we've updated the value in #6132. Shouldn't be strange anymore 😛

@konekoya
Copy link

konekoya commented Jan 7, 2019

Ah, sorry. I didn't read thru the whole thread.

@lock lock bot locked and limited conversation to collaborators Jan 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants