Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-error-overlay expose report runtime error #4705

Closed
hipstersmoothie opened this issue Jun 30, 2018 · 3 comments · Fixed by #4709
Closed

react-error-overlay expose report runtime error #4705

hipstersmoothie opened this issue Jun 30, 2018 · 3 comments · Fixed by #4709

Comments

@hipstersmoothie
Copy link
Contributor

hipstersmoothie commented Jun 30, 2018

I have some error that are caught by my app and call an onError function. I have the message and the stack trace inside this function. I can call reportBuildError but this doesn't use the stack trace at all.

I would like to have reportRuntimeError exposed so i can display the stack trace as well or the ability to include a stacktrace in the build error

@timneutkens
Copy link

I'm currently implementing react-error-overlay in Next.js and this would be a nice addition as currently, we have to throw an unhandled rejection which will end up in the error message (Unhandled Rejection (Error):). I already decoupled the handling logic on our side to swap the current method with this newly exposed reportRuntimeError if it gets accepted.

@hipstersmoothie
Copy link
Contributor Author

@timneutkens merged!

@timneutkens
Copy link

Thanks @hipstersmoothie, if you want you can implement the reporting in Next.js 💯

@lock lock bot locked and limited conversation to collaborators Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants