Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't create a valid PWA by default #4339

Closed
corysimmons opened this issue Apr 22, 2018 · 2 comments
Closed

Doesn't create a valid PWA by default #4339

corysimmons opened this issue Apr 22, 2018 · 2 comments

Comments

@corysimmons
Copy link

corysimmons commented Apr 22, 2018

Is this a bug report?

Yes

Did you try recovering your dependencies?

Yes

Which terms did you search for in User Guide?

  • lighthouse
  • pwa

Environment

  1. node -v 8.11.1:
  2. npm -v 5.6.0:
  3. npm ls react-scripts (if you haven’t ejected): 1.1.4

Then, specify:

  1. Operating system: macOS High Sierra
  2. Browser and version (if relevant): Chrome 65

Steps to Reproduce

Fresh CRA + Netlify w/ HTTPS ==> Lighthouse === not a valid PWA.

(Write your steps here:)

  1. create-react-app foo --use-npm
  2. Push app to Github
  3. Have Netlify manage it
  4. Associate with domain
  5. Use Netlify to generate Let's Encrypt cert
  6. Set "Deploy Settings" to "Build command: npm run build" and "Publish Directory: build"
  7. Verify site works/exists on https
  8. Run Lighthouse PWA audit
  9. See errors:

image

Here's the demo code (fresh CRA): https://github.com/corysimmons/test-cra-pwa-netlify/tree/55643ddf023d2eb4b267ca72f568268752ea398a

Here's the site: https://testing-1-2-3.com

The image sizes are easy enough for me to fix (although they should be in CRA tbh), but the Service worker does not successfully serve the manifest's start_url. confuses me.

I've tried changing the start_url to:

  • ./index.html
  • ./
  • .
  • index.html
  • https://testing-1-2-3.com
  • ./build
  • ./build/index.html

...and keep getting the same failure.

Related

@corysimmons
Copy link
Author

Per GoogleChrome/lighthouse#4541 (comment) it might be a false positive.

Is there anything CRA can do to help with this?

If not, CRA still needs 192 & 512 icons to make it valid (in Lighthouse's eyes anyway?).

@corysimmons
Copy link
Author

Apparently this really is just a false positive (even throws error on Google properties). It's up to you if you want to do the 192 + 512 icons. Closing

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant