Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make missing sass-loader a friendlier message #4333

Closed
Timer opened this issue Apr 21, 2018 · 5 comments
Closed

Make missing sass-loader a friendlier message #4333

Timer opened this issue Apr 21, 2018 · 5 comments
Milestone

Comments

@Timer
Copy link
Contributor

Timer commented Apr 21, 2018

Module build failed: Error: `sass-loader` requires `node-sass` >=4. Please install a compatible version.
@Timer Timer added this to the 2.0.0 milestone Apr 21, 2018
@miraage
Copy link

miraage commented Apr 27, 2018

sass-loader/loader.js

Does anybody see a way to catch this case except finding a node-sass substing in error?

@placenamehere
Copy link

I hit this error out of the box -- is there a missing dependency causing node-sass to not be installed? I think that's the issue, not the friendliness of the message

os x 10.13.4, yarn 1.6.0

  1. npx create-react-app@next --scripts-version=2.0.0-next.66cc7a90 test_cra
  2. rename App.css -> App.scss & update reference in App.js
  3. cd test_cra
  4. yarn start

@gaearon
Copy link
Contributor

gaearon commented May 22, 2018

No, it’s by design. You need to explicitly install node-sass as a dependency if you want to use it. Because we don’t want to add a binary dep like this by default (they often cause problems).

The fact that this wasn’t obvious from the message means it needs work.

@placenamehere
Copy link

Got it. Was trying to glean config info from the sass related PR/thread and didn't see that called out (or any other readme like changes).

@Timer
Copy link
Contributor Author

Timer commented May 24, 2018

Resolved by #4514

@Timer Timer closed this as completed May 24, 2018
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants