Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding font-smoothing to index.css #3892

Closed
goncy opened this issue Jan 22, 2018 · 2 comments
Closed

Adding font-smoothing to index.css #3892

goncy opened this issue Jan 22, 2018 · 2 comments

Comments

@goncy
Copy link
Contributor

goncy commented Jan 22, 2018

Without

image

With

image

index.css

  margin: 0;
  padding: 0;
  font-family: sans-serif;
  -webkit-font-smoothing: antialiased;
  -moz-osx-font-smoothing: grayscale;
}

I'm not a fan of having the prefixed properties on the index.css but just webkit and moz support it and with a different name, but i think that there is a lot of people that doesn't know this little trick and will be a good touch for apps with a lot of content. I can make a PR.

PD: Also a question, why the App header is fixed to 150px? If you remove it it's the same height but if you remove the logo or the text you have to remove the css line to get the correct height. Can make a PR also for that.

Before
image

After
image

@gaearon
Copy link
Contributor

gaearon commented Jan 22, 2018

We have a new template in the next branch with font smoothing on :-)
#3235

@gaearon gaearon closed this as completed Jan 22, 2018
@goncy
Copy link
Contributor Author

goncy commented Jan 22, 2018

Good to hear!, will check on that branch in what i can help, thanks!

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants