Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment to GitHub Pages #383

Closed
gesposito opened this issue Aug 6, 2016 · 7 comments
Closed

Deployment to GitHub Pages #383

gesposito opened this issue Aug 6, 2016 · 7 comments

Comments

@gesposito
Copy link

In order to provide a better DX, sticking to create-react-app's core ideas, I suggest replacing the manual steps of GitHub Pages deploy (the user has to setup a script himself?) with tools or setups like gh-pages.

Do you see any drawback for this?

I could take a look at it or let @tschaub take the honor.

@gaearon
Copy link
Contributor

gaearon commented Aug 6, 2016

Happy to review a PR doing this!

@winkerVSbecks
Copy link

@gesposito @gaearon how about something more minimal like: https://github.com/X1011/git-directory-deploy It's just a single shell script with no dependencies.

@gaearon
Copy link
Contributor

gaearon commented Aug 7, 2016

If we use something it must work good on Windows.

@Shastel
Copy link

Shastel commented Aug 15, 2016

Hi @gaearon. Probably we can use gh-pages package and create additional npm script, e.g. npm run deploy. Instead of using commandline interface of this package. From my point of view еhis gives us the ability to control output and error handling

@chibicode
Copy link
Contributor

We might be able to take advantage of this: https://github.com/blog/2228-simpler-github-pages-publishing

@gaearon
Copy link
Contributor

gaearon commented Sep 3, 2016

I feel that this is out of scope, especially now that it’s so simple to deploy to GH pages with /docs folder.

@gaearon gaearon closed this as completed Sep 3, 2016
@quantuminformation
Copy link

Gh-pages deployment would be much easier if there was a way to change the build output path from /static/foo.css to static/foo.css to make it work on gh-pages, without doing it manually.

That way I can deploy just be doing rm -rf build && git checkout gh-pages && git merge master && npm run build && git add build/* -f && git commit -a -m "build files" && git push origin gh-pages && git checkout master

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants