-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRA + proxy + HTTPS=true issues with OAuth flow #3245
Comments
Yes, i have the same issue the request with proxy doesn´t works & i don´t find info about it! Please help us |
I Solved it only by ejecting CRA and several additional steps to totally get rid of proxy. The main thing you need to edit after ejecting is You need to find all the |
Do you have a proposed fix we could apply on our side? |
I think you need to make proxy optional/configurable, so it could be easy to disable/enable without ejecting CRA. |
We've been trying to consolidate the proxy discussion in #3366. Could you please write your input there, and try to figure out with other posters what changes to the API/configuration would be ideal? Thanks. |
Now that I re-read your comment, I'm not sure I understand what happened. Proxy definitely is disabled by default. Yes, there is a call to prepare its config, but it returns undefined when there is no What you describe sounds either like a bug or a misunderstanding. Maybe passing Can you describe the symptoms in more detail so we can verify them? In particular I don't see how your first symptom (something doesn't work with OAuth when you do specify proxy) is related to your second symptom (something doesn't work when you don't specify proxy). |
The issue was: I develop with HTTPS=true env, so proxy didn't work with HTTPS=true for me at least. I think something was messing up with CORS, and I could fix it only after ejecting. Sorry I moved on very far since then, and can't reproduce it now. I think I had this issue with CRA 1.0.7 |
I see. I’m going to close this as there’s not enough detail for us to dig into this. But if somebody else encounters this, or you see it again, please file a new issue with a reproducing example. Thanks! |
Is this a bug report?
yes
Environment
node -v
: 8.3.0npm -v
: 5.4.2yarn --version
(if you use Yarn): 1.1.0npm ls react-scripts
(if you haven’t ejected):Operating system: OSX
Steps to Reproduce
npm start
script modified to enable self signed SSL certificate in CRA's package.json as it recommended by README:https://localhost:5000/auth/google
:Expected Behavior
Redirect to
https://accounts.google.com/signin/oauth/......
to confirm signup:Actual Behavior
Receiving error in browser:
PS: If I set proxy in package.json to HTTP instead of HTTPS:
and remove HTTPS=true from npm start script, everything works, but my paranoia tells me that in dev mode it is better to be protected, cos some malicious browser extensions could mess with the code.
Sorry, I do not have demo.
The text was updated successfully, but these errors were encountered: