Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppleScript issue #322

Closed
gaearon opened this issue Aug 1, 2016 · 9 comments
Closed

Fix AppleScript issue #322

gaearon opened this issue Aug 1, 2016 · 9 comments
Milestone

Comments

@gaearon
Copy link
Contributor

gaearon commented Aug 1, 2016

Found it on this video by @trevordmiller:

screen shot 2016-08-01 at 18 32 22

It says:

osascript: /Users/trevormiller/Google: No such file or directory

We should probably mute any warnings from osascript (since it’s optional anyway) but it would be nice to figure out what exactly failed here and why.

Relevant code.

@trevordmiller
Copy link

@gaearon Is this something I did wrong? Or do you need me to run any commands to send you logs or something?

@gaearon
Copy link
Contributor Author

gaearon commented Aug 1, 2016

You did nothing wrong, our AppleScript command to launch Google Chrome just failed for some reason. Maybe it always fails when Chrome is not open (need to check).

@trevordmiller
Copy link

@gaearon Thanks for checking out my video!

@gaearon
Copy link
Contributor Author

gaearon commented Aug 1, 2016

Thanks for recording! Would be cool to make a few more. Topic ideas:

@trevordmiller
Copy link

@gaearon For sure! Would you mind if I recorded these or would you like to do it?

@gaearon
Copy link
Contributor Author

gaearon commented Aug 1, 2016

Sure, go ahead, I can’t find the time now. 😄

@trevordmiller
Copy link

@gaearon Sounds good. Also, maybe "Extending react-scripts" to basically show how to add things like tests with npm scripts and &&; something like:

package.json

...
"scripts": {
  "test": "ava"
  "start": "npm-run-all npm run test -- -w && react-scripts start"
  "prebuild": "npm run test"
}
...

Do you think that would be helpful or would you recommend another approach?
Sorry I realize this is off-topic of this issue.

@gaearon
Copy link
Contributor Author

gaearon commented Aug 1, 2016

@trevordmiller This would be fine except you’ll probably want to explain how to do this on Windows too. This tool supports Windows (and we care about this).

@trevordmiller
Copy link

@gaearon Cool :)

@gaearon gaearon added this to the 0.3.0 milestone Aug 2, 2016
@gaearon gaearon closed this as completed in 44b8313 Aug 2, 2016
@lock lock bot locked and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants