-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in jsx-no-target-blank eslint rule #2774
Labels
Milestone
Comments
This should be resolved once jsx-eslint/eslint-plugin-react#1298 is released. |
jsx-eslint/eslint-plugin-react#129 is released now in 7.2.0 |
Does this still happen to you guys? Having the same error. |
This is happening to me too. |
Will be fixed in next release per plugin upgrade: #3146. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is this a bug report?
Yes
Can you also reproduce the problem with npm 4.x?
Yes
Which terms did you search for in User Guide?
N/A
Environment
node -v
: 7.8.0npm -v
: 4.2.0yarn --version
(if you use Yarn): 0.27.5npm ls react-scripts
(if you haven’t ejected): 1.0.10Then, specify:
Steps to Reproduce
a
tag withtarget="_blank" rel="noopener noreferrer"
and some styles fromglamor
yarn start
Expected Behavior
No errors.
Actual Behavior
Unexpected error in console:
TypeError: Cannot read property 'name' of undefined
in thejsx-no-target-blank
eslint rule.Additional Comments
I filed a bug in the eslint repo: jsx-eslint/eslint-plugin-react#1296
I am unable to reproduce this with a fresh app. This started occurring after upgrading from 1.0.4 to 1.0.10. I've tried removing
node_modules
andyarn.lock
and installing from scratch, but still get the same error.The text was updated successfully, but these errors were encountered: