-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to deal with webpack warning from unmaintained grandparent module? #1924
Comments
I suggest forking Unfortunately we're not going to add an escape hatch for this, so you will need to eject or live with the warning. You can check out Let me know if we can help with anything else. :) |
Longer term we aim to solve it here: webpack/webpack#4263 |
Not sure how you plan to fix it, but webpack/webpack#4381 was merged, once released you can use it to suppress those warnings. |
Oo that looks promising @timse. Can you please open a new proposal issue for us to talk details? Thanks! |
@gaearon now that the suppress warnings feature was added to webpack, do you plan to use it ? |
ill reopen an issue :) |
Can you add a link to the new issue? |
It's linked above your comment, #1947. |
Can you reproduce the problem with latest npm?
yes.
Description
Requiring
winston
generates a warning due to some webpack-warning-deserving code thatwinston
's dependency,colors
has.It's currently impossible AFAICT to tell eslint to ignore it.
I'm opening this bug here because it's impossible to e.g. disable the webpack warning
exprContextCritical
without ejecting, but using a very popular logging module shouldn't require ejecting.Alternatively, can anyone suggest an alternative to
winston
?Related issues:
colors
: safe mode behaves strangely when using with webpack Marak/colors.js#137winston
: Critical Dependencies: the request of a dependency is an expression winstonjs/winston#984Expected behavior
Adding
winston
to a CRA project should not add warnings on each page load, or it should be possible to deal with a "misbehaving" grandparent.Actual behavior
yields:
Environment
npm ls react-scripts
(if you haven’t ejected):node -v
:v7.7.2
npm -v
:4.4.4
Then, specify:
Reproducible Demo
See minimal repo at https://github.com/davidascher/webpack-warning/
The text was updated successfully, but these errors were encountered: